Update plugin-base and sentry #3127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ok, current issues left:
|
# Conflicts: # package-lock.json
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin infrastructure to version 3.x, specifically updating @iobroker/plugin-base from ~2.0.1 to ~3.0.3 and @iobroker/plugin-sentry from ~2.0.4 to ~3.0.0. The major change is that plugin lifecycle methods (initPlugin, destroy, destroyAll) are now asynchronous and must be properly awaited.
Key changes:
- All plugin lifecycle methods now return Promises and require
await - Import paths changed from
@iobroker/plugin-base/typesto@iobroker/plugin-base - Enhanced shutdown logic in adapter.ts to handle async plugin destruction with race condition prevention
- Type casting adjustments for plugin-base v3 API changes
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/types-dev/objects.d.ts | Grammar improvements in JSDoc comments |
| packages/controller/src/main.ts | Added await to plugin lifecycle methods; updated imports; changed Sentry plugin access pattern |
| packages/controller/package.json | Updated plugin-base to ~3.0.3, plugin-sentry to ~3.0.0, debug to ^4.4.3 |
| packages/cli/src/lib/setup/dbConnection.ts | Added await to destroyAll; added type casting for config; updated imports |
| packages/cli/package.json | Updated plugin-base to ~3.0.3, debug to ^4.4.3 |
| packages/adapter/src/lib/adapter/adapter.ts | Refactored terminate() with async shutdown logic; added await to all plugin methods; updated type declarations |
| packages/adapter/package.json | Updated plugin-base to ~3.0.3 |
| package-lock.json | Updated dependencies including Sentry 10.x with OpenTelemetry support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Plugin-base and Sentry to 3.x including relevant code changes to properly handle the logic on shutdown